From 9bf57b00633e25aeef44fe9ed2a0aaa197d6a677 Mon Sep 17 00:00:00 2001 From: Dawid Dziurla Date: Thu, 11 Jul 2019 18:52:19 +0200 Subject: [PATCH] defer closing right after checking error --- pkg/commands/container.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pkg/commands/container.go b/pkg/commands/container.go index f0a9f8e1..ae0ecd2f 100644 --- a/pkg/commands/container.go +++ b/pkg/commands/container.go @@ -370,6 +370,7 @@ func (c *Container) Attach() error { if err != nil { return err } + defer hijack.Close() fd := os.Stdin.Fd() oldState, err := term.MakeRaw(fd) @@ -416,7 +417,6 @@ func (c *Container) Attach() error { return err } - hijack.Close() return nil } }