mroot/lazydocker
1
0
Fork 0
mirror of https://github.com/jesseduffield/lazydocker.git synced 2026-07-22 07:11:01 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

Fix Docker API version compatibility by enabling proper version negotiation

Browse source 
Replace client.FromEnv with individual options to avoid WithVersionFromEnv
which prevents API version negotiation when DOCKER_API_VERSION is set

Co-authored-by: jesseduffield <8456633+jesseduffield@users.noreply.github.com>
This commit is contained in:
copilot-swe-agent[bot] 2025-12-19 22:55:12 +00:00
parent d7f5b3f701
commit a71fd954dd
1 changed files with 10 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

11
pkg/commands/docker.go
View file

@ -96,7 +96,16 @@ func NewDockerCommand(log *logrus.Entry, osCommand *OSCommand, tr *i18n.Translat
dockerHost = dockerHostFromEnv
}
cli, err := client.NewClientWithOpts(client.FromEnv, client.WithAPIVersionNegotiation(), client.WithHost(dockerHost))
// We avoid using client.FromEnv because it includes WithVersionFromEnv() which
// sets manualOverride=true when DOCKER_API_VERSION is set, preventing API version
// negotiation even when WithAPIVersionNegotiation() is specified.
// Instead, we manually configure TLS and host from environment, but always enable
// API version negotiation to support older Docker daemons.
cli, err := client.NewClientWithOpts(
client.WithTLSClientConfigFromEnv(),
client.WithAPIVersionNegotiation(),
client.WithHost(dockerHost),
)
if err != nil {
ogLog.Fatal(err)
}