mroot/lazydocker
1
0
Fork 0
mirror of https://github.com/jesseduffield/lazydocker.git synced 2026-07-25 08:31:03 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

Remove loader code for confirmation panel

Browse source 
It wasn't being used and if it were to be used, there would be a memory
leak
This commit is contained in:
Jesse Duffield 2024-05-26 14:04:07 +10:00
parent 968b09e6c4
commit cdf1d9ad11
1 changed files with 5 additions and 10 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

15
pkg/gui/confirmation_panel.go
View file

@ -7,7 +7,6 @@
package gui package gui
import ( import (
"context"
"strings" "strings"
"github.com/fatih/color" "github.com/fatih/color"
@ -65,7 +64,7 @@ func (gui *Gui) getConfirmationPanelDimensions(wrap bool, prompt string) (int, i
func (gui *Gui) createPromptPanel(title string, handleConfirm func(*gocui.Gui, *gocui.View) error) error { func (gui *Gui) createPromptPanel(title string, handleConfirm func(*gocui.Gui, *gocui.View) error) error {
gui.onNewPopupPanel() gui.onNewPopupPanel()
err := gui.prepareConfirmationPanel(title, "", false) err := gui.prepareConfirmationPanel(title, "")
if err != nil { if err != nil {
return err return err
} }
@ -73,17 +72,13 @@ func (gui *Gui) createPromptPanel(title string, handleConfirm func(*gocui.Gui, *
return gui.setKeyBindings(gui.g, handleConfirm, nil) return gui.setKeyBindings(gui.g, handleConfirm, nil)
} }
func (gui *Gui) prepareConfirmationPanel(title, prompt string, hasLoader bool) error { func (gui *Gui) prepareConfirmationPanel(title, prompt string) error {
x0, y0, x1, y1 := gui.getConfirmationPanelDimensions(true, prompt) x0, y0, x1, y1 := gui.getConfirmationPanelDimensions(true, prompt)
confirmationView := gui.Views.Confirmation confirmationView := gui.Views.Confirmation
_, err := gui.g.SetView("confirmation", x0, y0, x1, y1, 0) _, err := gui.g.SetView("confirmation", x0, y0, x1, y1, 0)
if err != nil { if err != nil {
return err return err
} }
confirmationView.HasLoader = hasLoader
if hasLoader {
gui.g.StartTicking(context.Background()) // TODO cancel this
}
confirmationView.Title = title confirmationView.Title = title
confirmationView.Visible = true confirmationView.Visible = true
gui.g.Update(func(g *gocui.Gui) error { gui.g.Update(func(g *gocui.Gui) error {
@ -101,10 +96,10 @@ func (gui *Gui) onNewPopupPanel() {
// The golangcilint unparam linter complains that handleClose is alwans nil but one day it won't be nil. // The golangcilint unparam linter complains that handleClose is alwans nil but one day it won't be nil.
// nolint:unparam // nolint:unparam
func (gui *Gui) createConfirmationPanel(title, prompt string, handleConfirm, handleClose func(*gocui.Gui, *gocui.View) error) error { func (gui *Gui) createConfirmationPanel(title, prompt string, handleConfirm, handleClose func(*gocui.Gui, *gocui.View) error) error {
return gui.createPopupPanel(title, prompt, false, handleConfirm, handleClose) return gui.createPopupPanel(title, prompt, handleConfirm, handleClose)
} }
func (gui *Gui) createPopupPanel(title, prompt string, hasLoader bool, handleConfirm, handleClose func(*gocui.Gui, *gocui.View) error) error { func (gui *Gui) createPopupPanel(title, prompt string, handleConfirm, handleClose func(*gocui.Gui, *gocui.View) error) error {
gui.onNewPopupPanel() gui.onNewPopupPanel()
gui.g.Update(func(g *gocui.Gui) error { gui.g.Update(func(g *gocui.Gui) error {
if gui.currentViewName() == "confirmation" { if gui.currentViewName() == "confirmation" {
@ -112,7 +107,7 @@ func (gui *Gui) createPopupPanel(title, prompt string, hasLoader bool, handleCon
gui.Log.Error(err.Error()) gui.Log.Error(err.Error())
} }
} }
err := gui.prepareConfirmationPanel(title, prompt, hasLoader) err := gui.prepareConfirmationPanel(title, prompt)
if err != nil { if err != nil {
return err return err
} }