mroot/yazi
1
0
Fork 0
mirror of https://github.com/sxyazi/yazi.git synced 2026-07-25 08:41:05 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

feat: avoid clone() reallocating memory

Browse source
This commit is contained in:
sxyazi 2024-04-30 01:34:49 +08:00
parent 0f02b9e348
commit 1091b0c199
No known key found for this signature in database
1 changed files with 10 additions and 12 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

22
yazi-core/src/which/commands/show.rs
View file

@ -1,6 +1,6 @@
use std::{collections::HashSet, str::FromStr}; use std::{collections::HashSet, str::FromStr};
use yazi_config::{keymap::{Control, ControlCow, Key}, KEYMAP}; use yazi_config::{keymap::{Control, Key}, KEYMAP};
use yazi_shared::{event::Cmd, render, Layer}; use yazi_shared::{event::Cmd, render, Layer};
use crate::which::{Which, WhichSorter}; use crate::which::{Which, WhichSorter};
@ -43,9 +43,17 @@ impl Which {
} }
pub fn show_with(&mut self, key: &Key, layer: Layer) { pub fn show_with(&mut self, key: &Key, layer: Layer) {
let mut seen = HashSet::new();
self.layer = layer; self.layer = layer;
self.times = 1; self.times = 1;
self.cands = keymap_candidates(layer, key); self.cands = KEYMAP
.get(layer)
.iter()
.filter(|c| c.on.len() > 1 && &c.on[0] == key)
.filter(|&c| seen.insert(&c.on))
.map(|c| c.into())
.collect();
WhichSorter::default().sort(&mut self.cands); WhichSorter::default().sort(&mut self.cands);
self.visible = true; self.visible = true;
@ -53,13 +61,3 @@ impl Which {
render!(); render!();
} }
} }
fn keymap_candidates(layer: Layer, key: &Key) -> Vec<ControlCow> {
let mut seen = HashSet::new();
let mut matches =
KEYMAP.get(layer).iter().filter(|c| c.on.len() > 1 && &c.on[0] == key).collect::<Vec<_>>();
matches.retain(|c| seen.insert(c.on.clone()));
matches.into_iter().map(|c| c.into()).collect()
}