From 52086ee14789e4c6d56b9b538af1f7e1b6297b90 Mon Sep 17 00:00:00 2001 From: sxyazi Date: Sun, 18 Feb 2024 00:12:12 +0800 Subject: [PATCH] Return true when inserting an empty list of urls --- yazi-core/src/tab/selected.rs | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/yazi-core/src/tab/selected.rs b/yazi-core/src/tab/selected.rs index 5c4e4a25..c49222a1 100644 --- a/yazi-core/src/tab/selected.rs +++ b/yazi-core/src/tab/selected.rs @@ -15,8 +15,9 @@ impl Selected { pub fn insert_many(&mut self, urls: &[&Url]) -> bool { if urls.is_empty() { - return false; + return true; } + let url_buf = urls[0].to_path_buf(); let mut current_path = url_buf.clone(); @@ -143,9 +144,9 @@ mod tests { let mut selected = Selected::default(); selected.insert(Url::from(Path::new("/parent"))); - let childs1 = Url::from(Path::new("/parent/child1")); - let childs2 = Url::from(Path::new("/parent/child2")); - let urls = vec![&childs1, &childs2]; + let child1 = Url::from(Path::new("/parent/child1")); + let child2 = Url::from(Path::new("/parent/child2")); + let urls = vec![&child1, &child2]; assert!(!selected.insert_many(&urls), "Should fail to insert since parent already exists"); } @@ -167,8 +168,7 @@ mod tests { #[test] fn insert_many_empty_urls_list() { let mut selected = Selected::default(); - let urls = vec![]; - assert!(!selected.insert_many(&urls), "Inserting an empty list of urls should false"); + assert!(selected.insert_many(&[]), "Inserting an empty list of urls should false"); } #[test]