refactor: replace format! with concat! for string literals

This commit is contained in:
Integral 2024-12-08 22:59:33 +08:00
parent b8b3ab9be3
commit 97c53bfa24
No known key found for this signature in database
GPG key ID: 06313911057DD5A8
4 changed files with 12 additions and 8 deletions

View file

@ -1,12 +1,14 @@
use super::Actions; use super::Actions;
impl Actions { impl Actions {
pub(super) fn version() -> String { pub(super) fn version() -> &'static str {
format!( concat!(
"{} ({} {})",
env!("CARGO_PKG_VERSION"), env!("CARGO_PKG_VERSION"),
" (",
env!("VERGEN_GIT_SHA"), env!("VERGEN_GIT_SHA"),
env!("VERGEN_BUILD_DATE") " ",
env!("VERGEN_BUILD_DATE"),
")"
) )
} }
} }

View file

@ -15,7 +15,7 @@ pub struct BodyHey {
impl BodyHey { impl BodyHey {
#[inline] #[inline]
pub fn owned(peers: HashMap<u64, Peer>) -> Body<'static> { pub fn owned(peers: HashMap<u64, Peer>) -> Body<'static> {
Self { peers, version: BodyHi::version() }.into() Self { peers, version: BodyHi::version().to_string() }.into()
} }
} }

View file

@ -18,13 +18,15 @@ impl<'a> BodyHi<'a> {
pub fn borrowed(abilities: HashSet<&'a str>) -> Body<'a> { pub fn borrowed(abilities: HashSet<&'a str>) -> Body<'a> {
Self { Self {
abilities: abilities.into_iter().map(Cow::Borrowed).collect(), abilities: abilities.into_iter().map(Cow::Borrowed).collect(),
version: Self::version(), version: Self::version().to_string(),
} }
.into() .into()
} }
#[inline] #[inline]
pub fn version() -> String { format!("{} {}", env!("CARGO_PKG_VERSION"), env!("VERGEN_GIT_SHA")) } pub fn version() -> &'static str {
concat!(env!("CARGO_PKG_VERSION"), " ", env!("VERGEN_GIT_SHA"))
}
} }
impl<'a> From<BodyHi<'a>> for Body<'a> { impl<'a> From<BodyHi<'a>> for Body<'a> {

View file

@ -92,7 +92,7 @@ impl Client {
} }
} }
if version != Some(BodyHi::version()) { if version.as_deref() != Some(BodyHi::version()) {
bail!( bail!(
"Incompatible version (Ya {}, Yazi {})", "Incompatible version (Ya {}, Yazi {})",
BodyHi::version(), BodyHi::version(),