diff --git a/yazi-core/src/manager/commands/hover.rs b/yazi-core/src/manager/commands/hover.rs index b24f6513..b909ec1d 100644 --- a/yazi-core/src/manager/commands/hover.rs +++ b/yazi-core/src/manager/commands/hover.rs @@ -56,10 +56,10 @@ impl Manager { } // Turn on tracing - if self.current_or(tab).hovered().is_some_and(|f| url == f.url) { + if self.current_or(tab).hovered().is_some_and(|h| h.url == url) { // `hover(Some)` occurs after user actions, such as create, rename, reveal, etc. // At this point, it's intuitive to track the location of this file regardless. - self.current_or_mut(tab).tracing = true; + self.current_or_mut(tab).trace = Some(url.urn_owned()); } } } diff --git a/yazi-core/src/manager/commands/update_files.rs b/yazi-core/src/manager/commands/update_files.rs index 9498f7f3..0be74d12 100644 --- a/yazi-core/src/manager/commands/update_files.rs +++ b/yazi-core/src/manager/commands/update_files.rs @@ -70,16 +70,12 @@ impl Manager { } fn update_current(tab: &mut Tab, op: Cow, tasks: &Tasks) { - let hovered = tab.hovered().filter(|_| tab.current.tracing).map(|h| h.urn_owned()); let calc = !matches!(*op, FilesOp::Size(..) | FilesOp::Deleting(..)); - let foreign = matches!(op, Cow::Borrowed(_)); + if !tab.current.update_pub(tab.id, op.into_owned()) { return; - } - - tab.current.repos(hovered.as_ref().map(|u| u.as_urn())); - if foreign { + } else if foreign { return; } @@ -109,11 +105,11 @@ impl Manager { |(p, n)| matches!(*op, FilesOp::Deleting(ref parent, ref urns) if *parent == p && urns.contains(n)), ); - let folder = tab.history.entry(op.cwd().clone()).or_insert_with(|| Folder::from(op.cwd())); - let hovered = folder.hovered().filter(|_| folder.tracing).map(|h| h.urn_owned()); - if folder.update_pub(tab.id, op.into_owned()) { - folder.repos(hovered.as_ref().map(|u| u.as_urn())); - } + tab + .history + .entry(op.cwd().clone()) + .or_insert_with(|| Folder::from(op.cwd())) + .update_pub(tab.id, op.into_owned()); if leave { tab.leave(()); diff --git a/yazi-core/src/tab/folder.rs b/yazi-core/src/tab/folder.rs index ecadc240..8715cc5e 100644 --- a/yazi-core/src/tab/folder.rs +++ b/yazi-core/src/tab/folder.rs @@ -4,7 +4,7 @@ use yazi_config::{LAYOUT, MANAGER}; use yazi_dds::Pubsub; use yazi_fs::{Cha, File, Files, FilesOp, FolderStage, Step}; use yazi_proxy::ManagerProxy; -use yazi_shared::{Id, url::{Url, Urn}}; +use yazi_shared::{Id, url::{Url, Urn, UrnBuf}}; pub struct Folder { pub url: Url, @@ -15,21 +15,21 @@ pub struct Folder { pub offset: usize, pub cursor: usize, - pub page: usize, - pub tracing: bool, + pub page: usize, + pub trace: Option, } impl Default for Folder { fn default() -> Self { Self { - url: Default::default(), - cha: Default::default(), - files: Files::new(MANAGER.show_hidden), - stage: Default::default(), - offset: Default::default(), - cursor: Default::default(), - page: Default::default(), - tracing: Default::default(), + url: Default::default(), + cha: Default::default(), + files: Files::new(MANAGER.show_hidden), + stage: Default::default(), + offset: Default::default(), + cursor: Default::default(), + page: Default::default(), + trace: Default::default(), } } } @@ -73,7 +73,7 @@ impl Folder { FilesOp::Upserting(_, files) => self.files.update_upserting(files), } - self.arrow(0); + self.repos(self.trace.clone().as_ref().map(|u| u.as_urn())); (stage, revision) != (self.stage, self.files.revision) } @@ -90,15 +90,14 @@ impl Folder { pub fn arrow(&mut self, step: impl Into) -> bool { let step = step.into() as Step; let mut b = if self.files.is_empty() { - (self.cursor, self.offset, self.tracing) = (0, 0, false); - false + (mem::take(&mut self.cursor), mem::take(&mut self.offset)) != (0, 0) } else if step.is_positive() { self.next(step) } else { self.prev(step) }; - self.tracing |= b; + self.trace = self.hovered().filter(|_| b).map(|h| h.urn_owned()).or(mem::take(&mut self.trace)); b |= self.squeeze_offset(); self.sync_page(false); @@ -107,7 +106,7 @@ impl Folder { pub fn hover(&mut self, urn: &Urn) -> bool { if self.hovered().map(|h| h.urn()) == Some(urn) { - return false; + return self.arrow(0); } let new = self.files.position(urn).unwrap_or(self.cursor) as isize; diff --git a/yazi-core/src/tab/tab.rs b/yazi-core/src/tab/tab.rs index 4cf9b0e3..e81a5ce6 100644 --- a/yazi-core/src/tab/tab.rs +++ b/yazi-core/src/tab/tab.rs @@ -123,22 +123,16 @@ impl Tab { return render!(); } - let hovered = f.hovered().filter(|_| f.tracing).map(|h| h.urn_owned()); f.files.set_show_hidden(self.pref.show_hidden); f.files.set_sorter(<_>::from(&self.pref)); render!(f.files.catchup_revision()); - render!(f.repos(hovered.as_ref().map(|u| u.as_urn()))); + render!(f.repos(f.trace.clone().as_ref().map(|u| u.as_urn()))); }; apply(&mut self.current); - if let Some(parent) = &mut self.parent { apply(parent); - - // The parent should always track the CWD - parent.hover(self.current.url.urn()); - parent.tracing = parent.hovered().map(|h| &h.url) == Some(&self.current.url); } self